Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed output #218

Closed
wants to merge 3 commits into from
Closed

fixed output #218

wants to merge 3 commits into from

Conversation

meet0806
Copy link

Type Of Change

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Any modification in the test cases
  • Any modification in the documentation

Checklist:

  • I have read and followed the contribution guideline.
  • I have checked to ensure there aren't other open Pull Requests for the same update/change.
  • All the test cases pass and new modifications in the production code are 100% covered.
  • I have made corresponding changes to the documentation.

Related Issue

Closing: #205

Description

Added given color in a stdout print statements

How Has This Been Tested?

using commands

Screenshots (if appropriate):

image

Additional info

@meet0806 meet0806 requested a review from a team as a code owner September 23, 2024 08:44
@janosmurai
Copy link
Contributor

Thanks for the PR @meet0806 !

Please note that issue #205 has a second part - implementing a pager mechanism. See for example the less unix tool as a reference. This is needed because in some cases the output of these commands can be a huge list and we got some feedback that a paging mechanism could help in navigation.

Hacktoberfest only starts on the first of October, so if you'd like this PR to count, I won't approve this issue until then.

@meet0806
Copy link
Author

Hacktoberfest only starts on the first of October, so if you'd like this PR to count, I won't approve this issue until then.

Okay, till then I will add changes related to pager

@janosmurai
Copy link
Contributor

Hi @meet0806

Do you still work on this issue?

@meet0806
Copy link
Author

Hi @meet0806

Do you still work on this issue?

No

@meet0806 meet0806 closed this Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janosmurai janosmurai Awaiting requested review from janosmurai janosmurai is a code owner automatically assigned from axem-solutions/persea

@vezdeneszter vezdeneszter Awaiting requested review from vezdeneszter vezdeneszter is a code owner automatically assigned from axem-solutions/persea

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@meet0806 @janosmurai